-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #67
base: main
Are you sure you want to change the base?
Conversation
added name/email to README
Updated README
fixing naming convention that prevented percentage calculations from working for 2021 file
Update Data-description-and-EDA.md
update to working viz to generalize with health index vars
Merge to final dataframe, now with SVI
Great work, @cgwhall! I just have a couple of suggestions on lib/merge_to_final_dataframe.py. Most of them are just aiming to make the code look more structured and make it easier to read for future users. All the functions I am suggesting still need docstrings. Also, please do not forget to briefly describe both of your
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @vkielb! Great work! I have no comments for now.
Greetings from Taiwan!
Beginning of the pull request into main.