Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard refactoring #655

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Wizard refactoring #655

wants to merge 3 commits into from

Conversation

Hzaakk
Copy link
Collaborator

@Hzaakk Hzaakk commented Jan 13, 2025

Description

Refactored all usage of wizard forms to remove duplicated code

Notes:

  • all instances of the wizard form seemed to be the exact same, with the only exception being whether they include selectize or not (i decided to always include it). There was also one case where instead of "next step", the button said "submit" but i assumed it was a typo and included the normal template.

Fixes #654

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ensuring some forms still work properly (e.g. new project request which also has selectize functionality that should work still)

PR Self Evaluation

Strikethrough things that don’t make sense for your PR.

  • My code follows the agreed upon best practices
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if needed)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in the appropriate modules
  • I have performed a self-review of my own code

@Hzaakk Hzaakk requested a review from matthew-li January 13, 2025 13:19
@Hzaakk Hzaakk self-assigned this Jan 13, 2025
@@ -28,23 +24,6 @@ <h1>Secure Directory: PI Selection</h1><hr>

<p>Select a PI of the project. This PI will be asked to sign a Researcher Use Agreement during the approval process.</p>

<form action="" method="post">
{% csrf_token %}
Copy link
Collaborator Author

@Hzaakk Hzaakk Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why there wasnt a "first step" and "previous" option here but I'm assuming it wouldn't hurt to include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant