Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing qrc tech file read bug in #863

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fixing qrc tech file read bug in #863

merged 1 commit into from
Jun 10, 2024

Conversation

vikramjain236
Copy link
Contributor

Hammer flow breaks on the physical-aware design flow in genus because genus only allows one file to be read for the qrc_tech_file attribute. To fix this, we have set this to always read the first index. We have also set the default value of the phys_flow_effort key to be none, and let the users decide the setting in their yml inputs.
Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@vikramjain236 vikramjain236 requested review from harrisonliew and cadeberkeley and removed request for cadeberkeley June 10, 2024 18:26
@harrisonliew harrisonliew added this pull request to the merge queue Jun 10, 2024
Merged via the queue into master with commit f22e154 Jun 10, 2024
4 checks passed
@harrisonliew harrisonliew deleted the fix_phys_flow branch June 10, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants