Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic bump, fix readthedocs w/ Poetry 1.8 #847

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

harrisonliew
Copy link
Contributor

@harrisonliew harrisonliew commented Mar 7, 2024

  • Poetry 1.8 broke readthedocs - implemented the temporary fix.
  • Also bumped to pydantic v2 (with requisite migration).
  • Added tests/ to mypy type checking.
  • Dev documentation updates.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew marked this pull request as draft March 7, 2024 00:19
@vighneshiyer
Copy link
Contributor

Thanks! There are a few pydantic APIs to update in tests which the bump-pydantic script doesn't seem to touch, not sure why that's not working, but we can fix these by hand.

Also, now may be a good time to add mypy -p tests to workflows/pr.yml. There have been failing typechecks for tests that we can patch in this PR too.

@harrisonliew harrisonliew marked this pull request as ready for review March 7, 2024 01:07
Copy link
Contributor

@vighneshiyer vighneshiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@harrisonliew harrisonliew added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit f42634e Mar 7, 2024
4 checks passed
@harrisonliew harrisonliew deleted the pydantic_bump branch March 7, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants