Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Units Overhaul Fixes #802

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Additional Units Overhaul Fixes #802

merged 2 commits into from
Oct 5, 2023

Conversation

dpgrubb13
Copy link
Contributor

Follow-on PR to #800.

  • Units Overhaul broke ASAP7, Sky130 flow (eg. in e2e, fails after parsing lib time_unit to "1ps";)
  • Fixes lib time_unit reading
  • Some more pipe-cleaning is needed to check capacitance value reading

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@dpgrubb13 dpgrubb13 added bug DO NOT MERGE Do not merge this PR labels Oct 5, 2023
hammer/utils/lib_utils.py Outdated Show resolved Hide resolved
@dpgrubb13 dpgrubb13 removed the DO NOT MERGE Do not merge this PR label Oct 5, 2023
@dpgrubb13 dpgrubb13 added this pull request to the merge queue Oct 5, 2023
Merged via the queue into master with commit 8aef227 Oct 5, 2023
3 checks passed
@dpgrubb13 dpgrubb13 deleted the units_fixes branch October 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants