Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowgraph constructions #773

Merged
merged 39 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
a15a4fb
basic flowgraph implementation
bdngo Dec 2, 2022
0f1f305
add visualization test
bdngo Jan 20, 2023
c513c7e
refactor
bdngo Jan 20, 2023
5030e1b
pre-branch
bdngo Jan 27, 2023
93eeac3
new backend
bdngo Jan 27, 2023
b49bf0b
rebase master with pypi packaging
bdngo Jan 27, 2023
f8fc5c5
preliminary run graph algo
bdngo Jan 30, 2023
05a4043
implementing graph running
bdngo Feb 1, 2023
e51170e
passing basic run test
bdngo Feb 3, 2023
4a41864
more cycle reduction tests
bdngo Feb 3, 2023
e81c1a0
better capture of errors
bdngo Feb 3, 2023
f6219f5
add serialization test
bdngo Mar 3, 2023
cbede14
using property decorators
bdngo Mar 3, 2023
62b262d
add step control and custom driver
bdngo Mar 10, 2023
36553c4
small linting fix
bdngo Mar 10, 2023
9465d20
graph runner should not raise exception
bdngo Mar 10, 2023
74685bd
add mermaid support
bdngo Mar 10, 2023
13c9f00
add test for mermaid
bdngo Mar 10, 2023
51bf5ea
implement and test auto-insertion of aux actions
bdngo Mar 23, 2023
3d1be77
update poetry.lock
bdngo Mar 24, 2023
02d0cf2
mermaid generator automatically writes to file
bdngo Mar 24, 2023
f8ae7e2
implement hook test and direct imports
bdngo Mar 24, 2023
1175163
change runner to iteratively run nodes via BFS
bdngo Mar 28, 2023
812b763
add mermaid support to docs
bdngo Mar 28, 2023
673adfa
simplify module imports
bdngo Mar 28, 2023
4fcb13d
rename test
bdngo Mar 28, 2023
1cbdcdd
start documentation
bdngo Mar 28, 2023
689a88a
fix wording
bdngo Apr 7, 2023
2159e63
bump packages
bdngo May 11, 2023
f450aa3
Merge branch 'master' into flowgraph
bdngo May 11, 2023
cf8c550
bump lock file, add typing marker
bdngo May 11, 2023
d326211
fix type-checking for networkx
bdngo May 11, 2023
9896bd2
Merge branch 'master' into flowgraph
bdngo Dec 1, 2023
8dce117
fix CI pipeline
bdngo Dec 1, 2023
842346f
migrate to current step control names
bdngo Jan 4, 2024
bbb047f
reorder sections
bdngo Jan 4, 2024
b75b62a
Merge branch 'master' into flowgraph
bdngo Jan 4, 2024
6ca70a5
make docs consistent
bdngo Jan 4, 2024
4b2a1ae
convert back to legacy names for plugging into backend
bdngo Jan 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions hammer/config/config_src.py
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,7 @@ def get_config(self) -> dict:
self.__config_cache_dirty = False
return self.__config_cache

@property
def get_config_types(self) -> dict:
"""
Get the types for the configuration of a database.
Expand Down Expand Up @@ -818,9 +819,9 @@ def get_setting_type(self, key: str, nullvalue: Any = None) -> Any:
:param nullvalue: Value to return for nulls.
:return: Data type of key.
"""
if key not in self.get_config_types():
if key not in self.get_config_types:
raise KeyError(f"Key type {key} is missing")
value = self.get_config_types()[key]
value = self.get_config_types[key]
return nullvalue if value is None else value

def set_setting_type(self, key: str, value: Any) -> None:
Expand All @@ -840,7 +841,7 @@ def has_setting_type(self, key: str) -> bool:
:param key: Desired key.
:return: True if the given setting exists.
"""
return key in self.get_config_types()
return key in self.get_config_types

def check_setting(self, key: str, cfg: Optional[dict] = None) -> bool:
"""
Expand All @@ -852,11 +853,11 @@ def check_setting(self, key: str, cfg: Optional[dict] = None) -> bool:

if cfg is None:
cfg = self.get_config()
if key not in self.get_config_types():
if key not in self.get_config_types:
self.logger.warning(f"Key {key} is not associated with a type")
return True
try:
exp_value_type = parse_setting_type(self.get_config_types()[key])
exp_value_type = parse_setting_type(self.get_config_types[key])
except ValueError as ve:
raise ValueError(f'Key {key} has an invalid outer type: perhaps you have "List" instead of "list" or "Dict" instead of "dict"?') from ve

Expand Down
Loading