Dedup simulation flags + Small VCS Cleanup #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinschmidt
approved these changes
Aug 22, 2020
I think there is no need at the moment to do that yet. We made a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixes #653
Type of change: other enhancement
Impact: other
Release Notes
Requires PR #654 to go be merged 1st. This PR deduplicates the simulator flags in Chipyard, does some minor VCS cleanup to put its
csrcdirectory in a similar place to Verilator, and removes the need for thelibpthreadlibrary.This is tested on multi-threaded Verilator, normal Verilator, as well as VCS.