Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ICGC gitops.json #8158

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Update ICGC gitops.json #8158

merged 4 commits into from
Dec 4, 2024

Conversation

FayBooker2
Copy link
Contributor

Per request of Trevar Simmons in CTDS Slack. https://cdis.slack.com/archives/CP24V8MUG/p1733241956938919

Environments

icgc.bionimbus.org

Description of changes

Added banner to portal/gitops.json announcing maintenance on Dec 6

@FayBooker2 FayBooker2 requested review from trevars, beamcb and a team as code owners December 3, 2024 17:53
trevars
trevars previously requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@trevars trevars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request to change the name.

icgc.bionimbus.org/portal/gitops.json Outdated Show resolved Hide resolved
@FayBooker2
Update gitops.json
4e9f2fb 
Modified site name
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

icgc.bionimbus.org

❌ etlMapping.yaml - gitops.json mismatch

  • Field error: Field [node_id] in explorerConfig.charts not found in etlMapping

FayBooker2
FayBooker2 commented Dec 4, 2024
View reviewed changes
Copy link
Contributor Author

@FayBooker2 FayBooker2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

@FayBooker2 FayBooker2 dismissed trevars’s stale review December 4, 2024 16:45

Corrected in subsequent pull

@FayBooker2 FayBooker2 merged commit 869dedd into master Dec 4, 2024
3 checks passed
@FayBooker2 FayBooker2 deleted the FayBooker2-patch-3 branch December 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beamcb beamcb beamcb approved these changes

@trevars trevars Awaiting requested review from trevars trevars is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FayBooker2 @trevars @beamcb