pam/integration-tests: Use Ubuntu Mono font for VHS tests by default

ubuntu · Nov 18, 2024 · c579afa · c579afa
1 parent 671525e
commit c579afa
Show file tree

Hide file tree

Showing 35 changed files with 302 additions and 461 deletions.
diff --git a/.github/workflows/qa.yaml b/.github/workflows/qa.yaml
@@ -20,6 +20,7 @@ env:
     ffmpeg
     openssh-client
     openssh-server
+    ubuntu-mono
 
   # In Rust the grpc stubs are generated at build time
   # so we always need to install the protobuf compilers

diff --git a/...ion-tests/testdata/TestCLIAuthenticate/golden/authenticate_user_switching_to_local_broker b/...ion-tests/testdata/TestCLIAuthenticate/golden/authenticate_user_switching_to_local_broker
@@ -56,8 +56,8 @@ Gimme your password
 
 
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "user-integration-switch-broker" exited with error (PAM exit code: 2
-5): The return value should be ignored by PAM dispatch
+PAM Authenticate() for user "user-integration-switch-broker" exited with error (PAM exit code: 25): The return
+ value should be ignored by PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
@@ -86,8 +86,8 @@ PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate
 
 
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "user-integration-switch-broker" exited with error (PAM exit code: 2
-5): The return value should be ignored by PAM dispatch
+PAM Authenticate() for user "user-integration-switch-broker" exited with error (PAM exit code: 25): The return
+ value should be ignored by PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...egration-tests/testdata/TestCLIAuthenticate/golden/autoselect_local_broker_for_local_user b/...egration-tests/testdata/TestCLIAuthenticate/golden/autoselect_local_broker_for_local_user
@@ -6,15 +6,15 @@ Username: root
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value shoul
-d be ignored by PAM dispatch
+PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value should be ignored b
+y PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value shoul
-d be ignored by PAM dispatch
+PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value should be ignored b
+y PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...n-tests/testdata/TestCLIAuthenticate/golden/autoselect_local_broker_for_local_user_preset b/...n-tests/testdata/TestCLIAuthenticate/golden/autoselect_local_broker_for_local_user_preset
@@ -1,22 +1,22 @@
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value shoul
-d be ignored by PAM dispatch
+PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value should be ignored b
+y PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value shoul
-d be ignored by PAM dispatch
+PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value should be ignored b
+y PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value shoul
-d be ignored by PAM dispatch
+PAM Authenticate() for user "root" exited with error (PAM exit code: 25): The return value should be ignored b
+y PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 >

diff --git a/.../TestCLIAuthenticate/golden/deny_authentication_if_current_user_is_not_considered_as_root b/.../TestCLIAuthenticate/golden/deny_authentication_if_current_user_is_not_considered_as_root
@@ -1,18 +1,16 @@
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
-PAM Error Message: could not get current available brokers: permission denied: this action is on
-ly allowed for root users. Current user is XXXX
+PAM Error Message: could not get current available brokers: permission denied: this action is only allowed for
+ root users. Current user is XXXX
 PAM Authenticate() for user "" exited with error (PAM exit code: 4): System error
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
-PAM Error Message: could not get current available brokers: permission denied: this action is on
-ly allowed for root users. Current user is XXXX
+PAM Error Message: could not get current available brokers: permission denied: this action is only allowed for
+ root users. Current user is XXXX
 PAM Authenticate() for user "" exited with error (PAM exit code: 4): System error
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...ion-tests/testdata/TestCLIAuthenticate/golden/deny_authentication_if_max_attempts_reached b/...ion-tests/testdata/TestCLIAuthenticate/golden/deny_authentication_if_max_attempts_reached
@@ -60,19 +60,17 @@ invalid password 'wrongpass', should be 'goodpass'
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Error Message: invalid password 'wrongpass', should be 'goodpass'
-PAM Authenticate() for user "user-integration-max-attempts" exited with error (PAM exit code: 7)
-: Authentication failure
+PAM Authenticate() for user "user-integration-max-attempts" exited with error (PAM exit code: 7): Authenticati
+on failure
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 PAM Error Message: invalid password 'wrongpass', should be 'goodpass'
-PAM Authenticate() for user "user-integration-max-attempts" exited with error (PAM exit code: 7)
-: Authentication failure
+PAM Authenticate() for user "user-integration-max-attempts" exited with error (PAM exit code: 7): Authenticati
+on failure
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...tion-tests/testdata/TestCLIAuthenticate/golden/deny_authentication_if_user_does_not_exist b/...tion-tests/testdata/TestCLIAuthenticate/golden/deny_authentication_if_user_does_not_exist
@@ -37,8 +37,7 @@ Username: user-unexistent
 PAM Error Message: can't select broker: user "user-unexistent" does not exist
 PAM Authenticate() for user "user-unexistent" exited with error (PAM exit code: 4): System error
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
@@ -68,7 +67,6 @@ dispatch
 PAM Error Message: can't select broker: user "user-unexistent" does not exist
 PAM Authenticate() for user "user-unexistent" exited with error (PAM exit code: 4): System error
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...egration-tests/testdata/TestCLIAuthenticate/golden/exit_authd_if_local_broker_is_selected b/...egration-tests/testdata/TestCLIAuthenticate/golden/exit_authd_if_local_broker_is_selected
@@ -35,8 +35,8 @@ Username: user-local-broker
 
 
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "user-local-broker" exited with error (PAM exit code: 25): The retur
-n value should be ignored by PAM dispatch
+PAM Authenticate() for user "user-local-broker" exited with error (PAM exit code: 25): The return value should
+ be ignored by PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
@@ -65,8 +65,8 @@ PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate
 
 
 PAM Info Message: auth=incomplete
-PAM Authenticate() for user "user-local-broker" exited with error (PAM exit code: 25): The retur
-n value should be ignored by PAM dispatch
+PAM Authenticate() for user "user-local-broker" exited with error (PAM exit code: 25): The return value should
+ be ignored by PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/pam/integration-tests/testdata/TestCLIAuthenticate/golden/exit_authd_if_user_sigints b/pam/integration-tests/testdata/TestCLIAuthenticate/golden/exit_authd_if_user_sigints
@@ -17,20 +17,18 @@ Gimme your password
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 Gimme your password
 PAM Error Message: cancel requested
-PAM Authenticate() for user "user-integration-sigint" exited with error (PAM exit code: 26): Cri
-tical error - immediate abort
+PAM Authenticate() for user "user-integration-sigint" exited with error (PAM exit code: 26): Critical error -
+immediate abort
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
 Gimme your password
 PAM Error Message: cancel requested
-PAM Authenticate() for user "user-integration-sigint" exited with error (PAM exit code: 26): Cri
-tical error - immediate abort
+PAM Authenticate() for user "user-integration-sigint" exited with error (PAM exit code: 26): Critical error -
+immediate abort
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...gration-tests/testdata/TestCLIChangeAuthTok/golden/exit_authd_if_local_broker_is_selected b/...gration-tests/testdata/TestCLIChangeAuthTok/golden/exit_authd_if_local_broker_is_selected
@@ -35,8 +35,8 @@ Username: user-local-broker
 
 
 PAM Info Message: chauthtok=incomplete
-PAM ChangeAuthTok() for user "user-local-broker" exited with error (PAM exit code: 25): The retu
-rn value should be ignored by PAM dispatch
+PAM ChangeAuthTok() for user "user-local-broker" exited with error (PAM exit code: 25): The return value shoul
+d be ignored by PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
@@ -65,8 +65,8 @@ PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate
 
 
 PAM Info Message: chauthtok=incomplete
-PAM ChangeAuthTok() for user "user-local-broker" exited with error (PAM exit code: 25): The retu
-rn value should be ignored by PAM dispatch
+PAM ChangeAuthTok() for user "user-local-broker" exited with error (PAM exit code: 25): The return value shoul
+d be ignored by PAM dispatch
 PAM AcctMgmt() exited with error (PAM exit code: 26): Critical error - immediate abort
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/pam/integration-tests/testdata/TestCLIChangeAuthTok/golden/exit_authd_if_user_sigints b/pam/integration-tests/testdata/TestCLIChangeAuthTok/golden/exit_authd_if_user_sigints
@@ -17,20 +17,18 @@ Gimme your password
 > ./pam_authd passwd socket=${AUTHD_TESTS_CLI_AUTHTOK_TESTS_SOCK}
 Gimme your password
 PAM Error Message: cancel requested
-PAM ChangeAuthTok() for user "user-integration-sigint" exited with error (PAM exit code: 26): Cr
-itical error - immediate abort
+PAM ChangeAuthTok() for user "user-integration-sigint" exited with error (PAM exit code: 26): Critical error -
+ immediate abort
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd passwd socket=${AUTHD_TESTS_CLI_AUTHTOK_TESTS_SOCK}
 Gimme your password
 PAM Error Message: cancel requested
-PAM ChangeAuthTok() for user "user-integration-sigint" exited with error (PAM exit code: 26): Cr
-itical error - immediate abort
+PAM ChangeAuthTok() for user "user-integration-sigint" exited with error (PAM exit code: 26): Critical error -
+ immediate abort
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
diff --git a/...egration-tests/testdata/TestCLIChangeAuthTok/golden/prevent_change_password_if_auth_fails b/...egration-tests/testdata/TestCLIChangeAuthTok/golden/prevent_change_password_if_auth_fails
@@ -60,19 +60,17 @@ invalid password 'wrongpass', should be 'goodpass'
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd passwd socket=${AUTHD_TESTS_CLI_AUTHTOK_TESTS_SOCK}
 PAM Error Message: invalid password 'wrongpass', should be 'goodpass'
-PAM ChangeAuthTok() for user "user-integration-max-attempts" exited with error (PAM exit code: 7
-): Authentication failure
+PAM ChangeAuthTok() for user "user-integration-max-attempts" exited with error (PAM exit code: 7): Authenticat
+ion failure
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────
 > ./pam_authd passwd socket=${AUTHD_TESTS_CLI_AUTHTOK_TESTS_SOCK}
 PAM Error Message: invalid password 'wrongpass', should be 'goodpass'
-PAM ChangeAuthTok() for user "user-integration-max-attempts" exited with error (PAM exit code: 7
-): Authentication failure
+PAM ChangeAuthTok() for user "user-integration-max-attempts" exited with error (PAM exit code: 7): Authenticat
+ion failure
 PAM Info Message: acct=incomplete
-PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM
-dispatch
+PAM AcctMgmt() exited with error (PAM exit code: 25): The return value should be ignored by PAM dispatch
 >
 ────────────────────────────────────────────────────────────────────────────────