-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve golden file error messages #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
improve-golden-file-errors
branch
3 times, most recently
from
November 12, 2024 11:03
94c482a
to
e3fe65e
Compare
adombeck
force-pushed
the
improve-golden-file-errors
branch
2 times, most recently
from
November 12, 2024 20:27
73e60d9
to
efe4aa8
Compare
3v1n0
reviewed
Nov 12, 2024
adombeck
force-pushed
the
improve-golden-file-errors
branch
from
November 12, 2024 22:15
a45bf0d
to
baa56bc
Compare
The function does not do any dconf database filtering
* Remove the "Filtering" part from the name because the function doesn't do any filtering * Mention that it can also update the golden files
We don't need to pass it, the function can access the package variable instead.
Move function calls out of require.NoError for improved readability.
adombeck
force-pushed
the
improve-golden-file-errors
branch
from
November 13, 2024 15:56
baa56bc
to
3289ef3
Compare
Print the content in multiple lines instead of a single line.
Use delta to colorize the diff of mismatching golden files if delta is found in the PATH.
adombeck
force-pushed
the
improve-golden-file-errors
branch
from
November 13, 2024 16:18
3289ef3
to
f9c3cde
Compare
According to ubuntu/authd#583 (comment), there was a discussion before about changing the Ubuntu version used in our GitHub workflows from jammy to noble, and it was decided that we want to stay on jammy for some reason. If that is correct, I'll have to revert 79afbac, and then we won't have the nice output from delta in our test output. I could live with that, but I wonder why we want to stay on jammy. |
adombeck
force-pushed
the
improve-golden-file-errors
branch
from
November 18, 2024 13:07
f9c3cde
to
838e863
Compare
denisonbarbosa
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDENG-5195
This changes the error message from:
to
If
delta
is installed on the system, the diff is also colorized: