chore(deps): update module github.com/gorilla/schema to v1.4.1 [security] - autoclosed

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
github.com/gorilla/schema	v1.2.0 -> v1.4.1

GitHub Vulnerability Alerts

CVE-2024-37298

Details

Running schema.Decoder.Decode() on a struct that has a field of type []struct{...} opens it up to malicious attacks regarding memory allocations, taking advantage of the sparse slice functionality. For instance, in the Proof of Concept written below, someone can specify to set a field of the billionth element and it will allocate all other elements before it in the slice.

In the local environment environment for my project, I was able to call an endpoint like /innocent_endpoint?arr.10000000.X=1 and freeze my system from the memory allocation while parsing r.Form. I think this line is responsible for allocating the slice, although I haven't tested to make sure, so it's just an educated guess.

Proof of Concept

The following proof of concept works on both v1.2.0 and v1.2.1. I have not tested earlier versions.

package main

import (
	"fmt"

	"github.com/gorilla/schema"
)

func main() {
	dec := schema.NewDecoder()
	var result struct {
		Arr []struct{ Val int }
	}
	if err := dec.Decode(&result, map[string][]string{"arr.1000000000.Val": {"1"}}); err != nil {
		panic(err)
	}
	fmt.Printf("%#+v\n", result)
}

Impact

Any use of schema.Decoder.Decode() on a struct with arrays of other structs could be vulnerable to this memory exhaustion vulnerability. There seems to be no possible solution that a developer using this library can do to disable this behaviour without fixing it in this project, so all uses of Decode that fall under this umbrella are affected. A fix that doesn't require a major change may also be harder to find, since it could break compatibility with some other intended use-cases.

---

Release Notes

gorilla/schema (github.com/gorilla/schema)

v1.4.1

Compare Source

Security Release

Fixes an issue where sparse slice deserialization can cause memory exhaustion CVE-2024-37298

Thanks to @​AlexVasiluta for the report and following responsible disclosure.

Full Changelog: gorilla/schema@v1.4.0...v1.4.1

v1.4.0

Compare Source

What's Changed

• feat: if a different type in slice, raise error by @​lll-lll-lll-lll in https://github.com/gorilla/schema/pull/212
• fixed panic: reflect: indirection through nil pointer to embedded struct by @​morus12 in https://github.com/gorilla/schema/pull/211

New Contributors

• @​lll-lll-lll-lll made their first contribution in https://github.com/gorilla/schema/pull/212

Full Changelog: gorilla/schema@v1.3.0...v1.3.1

v1.3.0

Compare Source

What's Changed

• Remove log.Fatal() usage in encoder.go by @​h2570su in https://github.com/gorilla/schema/pull/207
• Add default tag by @​zak905 in https://github.com/gorilla/schema/pull/183
• update readme: add informations about the default tag option usage by @​zak905 in https://github.com/gorilla/schema/pull/209

New Contributors

• @​h2570su made their first contribution in https://github.com/gorilla/schema/pull/207
• @​zak905 made their first contribution in https://github.com/gorilla/schema/pull/183

Full Changelog: gorilla/schema@v1.2.1...v1.3.0

v1.2.1

Compare Source

What's Changed

• build: use build matrix; drop Go <= 1.10 by @​elithrar in https://github.com/gorilla/schema/pull/147
• doc: Update README CI badge by @​elithrar in https://github.com/gorilla/schema/pull/148
• docs: remove travis badge by @​elithrar in https://github.com/gorilla/schema/pull/149
• build: fix config.yml by @​elithrar in https://github.com/gorilla/schema/pull/150
• [bug] Registered encoder doesn't work for struct pointer types by @​tkhametov in https://github.com/gorilla/schema/pull/174
• Update README.md by @​coreydaley in https://github.com/gorilla/schema/pull/197
• [GPT-98] Update go version & add verification/testing tools by @​apoorvajagtap in https://github.com/gorilla/schema/pull/200
• fix misspell by @​YuyaAbo in https://github.com/gorilla/schema/pull/192
• Update issues.yml by @​coreydaley in https://github.com/gorilla/schema/pull/201
• update GitHub workflows by @​coreydaley in https://github.com/gorilla/schema/pull/205

New Contributors

• @​tkhametov made their first contribution in https://github.com/gorilla/schema/pull/174
• @​coreydaley made their first contribution in https://github.com/gorilla/schema/pull/197
• @​apoorvajagtap made their first contribution in https://github.com/gorilla/schema/pull/200
• @​YuyaAbo made their first contribution in https://github.com/gorilla/schema/pull/192

Full Changelog: gorilla/schema@v1.2.0...v1.2.1

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.