-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor package rename script to support all kernel versions #259
Conversation
@p5 confirming I understand the purpose here. This keeps the same general behavior as before, but is safe for future kernel versions. Correct? |
Exactly. If it worked. |
https://github.com/ublue-os/akmods/actions/runs/11465079157/job/31902747757#step:12:3007
|
I would suggest gutting the logic and just checking if -6 exists in the string and only doing the sub then. Much simpler for now. |
I did some "println debugging" and saw this:
The I'll push a fix momentarily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only does this make this work for future kernels, this fixes an issue where we were incorrectly renaming RPMs which did NOT have the kernel string in their filename. (eg, ZFS library RPMs).
Updates the RPM renaming script to read the kernel version from the installed kernel-core RPM, removing that string from the package names if it exists.