libublksrv: Build fixes for 32-bit systems and external integration #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ublksrv needs _GNU_SOURCE defined for using cpu_set_t. While integrating with external build system like AOSP, these are defined using CFLAGS (-D_GNU_SOURCE). This causes _GNU_SOURCE redefined build errors so let's wrap this definition under ifndef which will preserve original intention while making the integration easier. Signed-off-by: Sandeep Dhavale <[email protected]>
ming1
reviewed
Nov 12, 2024
dhavale
commented
Nov 12, 2024
dhavale
force-pushed
the
android_compat
branch
2 times, most recently
from
8cc5188 to
877b9ce
Compare
eventfd expects 8-bytes unsigned integer (uint64_t) for read/writes. Instead of using native data types which can have different sizes on 32-bit platforms, use uint64_t to make this explicit throughout. Signed-off-by: Sandeep Dhavale <[email protected]>
dhavale
force-pushed
the
android_compat
branch
from
877b9ce to
fbd3431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 commits in this request
#ifndefso we avoid redefinition build errors