Default labels #506
Default labels #506
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.github/ubiquibot-config.yml
Outdated
| users: | ||
| pavlovcik: | ||
| - "Time: <1 Hour" | ||
| - "Priority: 0 (Normal)" |
There was a problem hiding this comment.
Pretty cool you implemented this but I still fear that we'll need to remove this when we implement the database style config so that we don't confuse future partners when they have conflicting settings e.g.
/default-labels @pavlovcik "Time: <1 Hour" "Priority: 0 (Normal)"
users:
pavlovcik:
- "Time: <1 Day"
- "Priority: 1 (Medium)"
| @@ -47,6 +47,40 @@ To test the bot, you can: | |||
| 2. Add a time label, ex: `Time: <1 Day` | |||
| 3. At this point the bot should add a price label. | |||
|
|
|||
| ## Configuration | |||
There was a problem hiding this comment.
You did a great job here thanks.
.github/ubiquibot-config.yml
Outdated
| - "Priority: 0 (Normal)" | ||
| - "Test" | ||
| users: | ||
| pavlovcik: |
There was a problem hiding this comment.
oh no. seems better to use @ubiquity-bounties instead of @pavlovcik lol
.github/ubiquibot-config.yml
Outdated
| default-labels: | ||
| global: | ||
| - "Time: <1 Hour" | ||
| - "Priority: 0 (Normal)" | ||
| - "Test" | ||
| users: | ||
| pavlovcik: | ||
| - "Time: <1 Hour" | ||
| - "Priority: 0 (Normal)" |
There was a problem hiding this comment.
There's one thing I forgot to highlight @whilefoo but #500 (comment)
Would you mind refactoring this config to be like this:
| default-labels: | |
| global: | |
| - "Time: <1 Hour" | |
| - "Priority: 0 (Normal)" | |
| - "Test" | |
| users: | |
| pavlovcik: | |
| - "Time: <1 Hour" | |
| - "Priority: 0 (Normal)" | |
| default-labels: | |
| - "Time: <1 Hour" | |
| - "Priority: 0 (Normal)" | |
| - "Test" |
I was on the fence about letting this slide but as I think about it more I'm just concerned that it'll cause conflicting config issues when we implement the slash command.
|
what's stopping this from merging? |
That is unusual. GitHub iOS client UI doesn't tell me any useful information on it. @0xcodercrane do you know why |
Looks like related to unresolved conversations |
Resolves #500
QA issue: whilefoo#4