feat: migration to SDK #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify code by replacing EnvConfigType with EnvConfig and refactor to use createPlugin.
Replace module-specific configurations with context plugin.
Simplify code by replacing EnvConfigType with EnvConfig and refactor to use createPlugin.
# Conflicts: # src/parser/permit-generation-module.ts # src/run.ts
Deleted github-comment-module-instance.ts, octokit.ts, and yarn.lock to clean up unused code.
Deleted config-reader and logger modules, simplifying configuration handling.
Reorganized imports to source BaseModule from module types instead of processor.
Reorganized imports to source BaseModule from module types instead of processor.
Swapped console.warn with logger.error for better logging, simplified issue payload.
Changed `dev` script to `bun --watch`, added new config to `issue.http`.
Add ContextPlugin type imports and instantiate testing modules.
Add ContextPlugin type imports and instantiate testing modules.
Updated error logging to use this.context.logger for consistency.
Enhanced the log message to provide better context about the issue.
Updated package.json dependency and fixed static test data in issue.http.
Add Bun package manager version to package.json for consistency.
Deleted validator.ts file. Updated package.json and removed related imports and test code.
Remove unnecessary blank line in CHANGELOG.md for better readability.
Add proper schema-based configs and remove redundant test case.
Update Octokit import style and replace jest.mock with jest.unstable_mockModule
Replaced manual mocks with jest.unstable_mockModule for consistency.
Refactored test context setup for shared usage and efficiency.
gentlementlegen
force-pushed
the
feat/local-run
branch
from
421ba43
to
02464f5
Compare
Refactor to use plugin-sdk in place of ubiquity-os-kernel.
|
@whilefoo to fix that whole mess I ended up creating a separate repo for the SDK to avoid circular references and allow this to compile I will update the kernel accordingly. Running plugin as SDK: https://github.com/Meniole/text-conversation-rewards/actions/runs/11723241994/job/32654486608#step:3:17 |
gentlementlegen
merged commit 11d9092
into
ubiquity-os-marketplace:development
3 checks passed
|
@gentlementlegen, this task has been idle for a while. Please provide an update. |
|
Interesting, I guess no message should have been posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #102
Depends on ubiquity-os/ubiquity-os-kernel#169
I decided to split the local runs into two major parts:
Technically this PR already allows for local runs using the SDK and
bunbut doesn't fulfill the specs, because it would be too much of a huge pull-request to read (adding caching etc. is missing). The SDK greatly helps for subsequent steps. Changing tobunwill allow easier local runs as well.Changes
ESM
Our SDK mainly supports ESM packages so I migrated all the code and tests to be ESM compatible.
Bun
Why bun?
bunis used in the Kernel and allows forbun link(this command was not cross compatible with bun and yarn). It also supports running a server out of the box with hono, so no need to write code to start a local server.Cons:
bunis still too immature and does not support properly network request mocking soyarnandjestare still needed for testing.