-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sdk #16
feat: sdk #16
Conversation
Replace custom logger with @ubiquity-os/ubiquity-os-logger and update types.
Removed server start code and simplified plugin initialization.
Removed @hono/node-server from dependencies in package.json and updated GitHub Action workflow.
Updated wrangler version, renamed node_compat to nodejs_compat, and enabled observability.
Updated wrangler.toml configuration, package scripts, and dependency versions.
Replaces console log and explicit return with simplified promise chaining.
Changed type casting in tests from PluginInputs to CommandContext to match updated codebase.
Renamed src/worker.ts to src/index.ts and updated relevant references.
Unused dependencies (2)
|
Remove trailing commas to conform to JSON standards.
Deleted `validator.ts` and removed associated packages from dependencies.
Added `dist` to ignore lists in relevant config files.
Added `dist` to ignore lists in relevant config files.
# Conflicts: # dist/index.js
Cleanup to remove unused '@octokit/rest' and '@octokit/webhooks' dependencies.
/query @gentlementlegen |
|
/query @gentlementlegen |
|
@whilefoo I had a question. Now that we have the SDK, I included it in this plugin. Everything seems fine but now every time it runs the verification fails. Shall this plugin have something set in the environment (although I see there is already a public key included) or is it something missing on the kernel side? PS: I guess it will void this pull request: #4 |
Include pluginSettingsSchema in createPluginWithEnv for enhanced validation.
@whilefoo thank you I missed that step, I got it to work with my own workers. That raises a few questions on my side: First, the SDK will probably have to be changed because for the environment it reads
|
Added logger, adapters, env, and octokit to CommandContext in tests for better initialization.
Updated test assertions to use resolves instead of async functions.
Eliminated unnecessary console.log statements from run.ts and query-user.ts.
Adjusted the error comment formatting to properly display code block.
/query @gentlementlegen |
|
The Hono server automatically reads the env from Cloudflare fetch or from |
Added envSchema to ensure environment variables are validated.
Updated @ubiquity-os/ubiquity-os-kernel to version 2.3.0.
@whilefoo Updated and upgraded the kernel, tried to simplify the |
Resolves #15