Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] add noble to testing matrix #22

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

mikaelarguedas
Copy link
Contributor

@mikaelarguedas mikaelarguedas commented Nov 14, 2024

Open questions:

  • Maybe workflow time is problematic and can't afford to add more jobs
  • If adding a new distro maybe need more than one job and different parameters

⚠️ this is a draft, but need to be opened as real PR for workflows to trigger

Signed-off-by: Mikael Arguedas <[email protected]>
@mikaelarguedas mikaelarguedas marked this pull request as ready for review November 14, 2024 09:39
@rhaschke
Copy link
Member

Why do you want to add noble to the matrix? The CI workflow is just intended to validate that both kinds of packages (python/catkin) can be built in principle and that error reporting works as expected.
Consider this workflow as a validation of the "build farm" itself.

@mikaelarguedas
Copy link
Contributor Author

I was thinking that it would allow finding the type of issues I faced in #18

@rhaschke
Copy link
Member

I was thinking that it would allow finding the type of issues I faced in #18

No, having a noble job in the CI workflow wouldn't have discovered the docker issue. For that, we should add noble in the docker workflow, which is definitely a good idea to do...

@rhaschke rhaschke merged commit 9427f0c into ubi-agni:main Nov 14, 2024
10 checks passed
@mikaelarguedas mikaelarguedas deleted the ci_test_against_noble branch November 14, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants