-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncronize camera_info with images #38
base: noetic-devel
Are you sure you want to change the base?
Conversation
I think this PR should be extended to allow different resolutions per stream type (probably RGB and SEGMENT should use the same) , justifying the need of individual camera infos. To better replicate real setups. |
Are you sure. Usually, camera_info topics are latched and simply provide a fixed message. Therefore, the timestamp shouldn't be relevant. |
Atleast our cameras do that. By rep-0104
|
- give each image from cameras its own topic - add configuration for camera topics This changes cameras to publish a syncronized camera_info for each image. e.g for rgb image: /mujoco_server/cameras/camera_name/rgb/camera_info /mujoco_server/cameras/camera_name/rgb/image_raw Additional configuration options to change topics: camera_name/topic: defaults to "/mujoco_server/cameras/camera_name" camera_name/name_rgb: default to "rbg" camera_name/name_depth: default to "depth" camera_name/name_segment: default to "segmented"
442d16f
to
ad25935
Compare
I changed the offscreen_camera to have a The topics are now configurable such that:
is used as default - which should match real camera setups. |
Description
camera_info needs to have the same timestamp as the images. (e.g. for usage with
message_filters.TimeSynchronizer
)This changes cameras to publish a syncronized camera_info for each image. e.g for rgb image:
/mujoco_server/cameras/camera_name/rgb/camera_info
/mujoco_server/cameras/camera_name/rgb/image_raw
Additional configuration options to change topics:
camera_name/topic
: defaults to "/mujoco_server/cameras/camera_name"camera_name/name_rgb
: default to "rbg"camera_name/name_depth
: default to "depth"camera_name/name_segment
: default to "segmented"Checklist