Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sound #128

Merged
merged 5 commits into from
Mar 19, 2021
Merged

Fix for sound #128

merged 5 commits into from
Mar 19, 2021

Conversation

MrSpiffyClean
Copy link
Contributor

Possible fix to #123.

(I apologize for the commit history, I think I didn't rebase when resyncing my fork)

@ubershmekel
Copy link
Owner

@MrSpiffyClean
Copy link
Contributor Author

Did you remember to check the sound checkbox on the lower left panel?

@ubershmekel ubershmekel merged commit c0bbbd5 into ubershmekel:master Mar 19, 2021
@ubershmekel
Copy link
Owner

Strange. I definitely did then. And now when I went to look at the link - the sound was not working, I clicked the sound checkbox, still no sound. I refreshed after setting the sound to on, then it did work. Now it works no matter how the checkbox is initially. The issue might be something that was cached in my system somehow.

Thank you so much @MrSpiffyClean !

@MrSpiffyClean
Copy link
Contributor Author

There might be some syncing issues with the video and audio being retrieved at different times, but after a repeat stuff seems to sort itself out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants