Proof of concept PR for numba guvectorized functions for setting value and norm for a field.
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lang-m
reviewed
Nov 11, 2022
There was a problem hiding this comment.
I think it would be good to integrate this functionality during the refactoring. The benefit can be significant I guess and just documenting how to do it manually is not very user-friendly (at least for me as a user). Some questions/comments:
- Do we have some actual numbers on the speed-up depending on cell size and complexity?
- The implementation should go to
_as_array(-> the callable implementation). - I would suggest to use
try ... except, try numba first and if it fails use the simple for loop (+ logging, maybe debug level, to know what is going on).
| self.array = _as_array(val, self.mesh, self.dim, dtype=self.dtype) | ||
| if callable(val): | ||
| nb_value_func = nb.guvectorize( | ||
| [(nb.float64[:], nb.float64[:])], "(n)->(n)", nopython=True |
There was a problem hiding this comment.
What happens if nopython=True is wrong? Is it ignored or does it raise an exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.