[on hold] Implement roles for volume buttons: none, text size, send history

[zopieux]

Keeps the default setting to "text size" for backwards compatibility. This implements feature request #281.

Change summary:

• preferences: replaces volume button for text-size checkbox with a dropdown with three choices: do nothing, text size, navigate send history
• change implementation in BufferFragment to account for the new setting

Note that when the user starts to type something in uiInput then decides to navigate history, this draft is stored so they can come back to it by pressing volume down all the way.

[oakkitten]

this works, but has a couple of problems (perhaps insignificant)

first, we only keep 3 fragments (current one and 2 to the sides of the current) and when you scroll farther they get destroyed, and this will screw things a bit; also there some other ways to destroy a fragment

second, the code could perhaps be more eloquent? maybe only store current input when you push up for the first time and get rid of uiInputSetProgrammatically and move more things to one place. also lines 475-476 get duplicated, and stuff like that

i don't mind this otherwise, me

[zopieux]

@oakkitten

first, we only keep 3 fragments (current one and 2 to the sides of the current) and when you scroll farther they get destroyed

Where would you suggest I store my state? Would it be okay/needed to persist it as app data (on disk)?

second, the code could perhaps be more eloquent? maybe only store current input when you push up for the first time and get rid of uiInputSetProgrammatically and move more things to one place. also lines 475-476 get duplicated, and stuff like that

I'll review this kind of stuff once I know where to put the state so it does not get destroyed with the fragment.

[oakkitten]

Where would you suggest I store my state?

if you want to store it—not like we can't live without it, after all it's option—

one way is inside the fragment (some bundle is passed in onCreate)
another is making some kind of manual storage (this will help preserve state when user presses back)
another is storing everything in BufferList which is static
another is getting rid of the fragments and and all the stupid clutches that are needed for fragments and just put Views into ViewPager...

another thing, if there's any storage per buffer we could store more things, like current position in chat (sucks when you scroll up in chat and click a link and then get back and it's on the bottom again) or something else

perhaps join #weechat-android on freenode?

[zopieux]

Superseded by #554.