Implement roles for volume buttons: do nothing, change text size, navigate sent history #554
Conversation
…igate sent history The navigation state is saved and restored along with BufferFragment's lifecycle. The deprecated preference is migrated to the correspondig volume role.
| <string name="pref_buttons_volume__actions__none">Ничего не делать</string> | ||
| <string name="pref_buttons_volume__actions__text_size">Кнопки громкости меняют размер текста</string> | ||
| <string name="pref_buttons_volume__actions__history">Навигация по истории отправлений</string> |
There was a problem hiding this comment.
Machine-translated, probably wrong.
| <string name="pref_buttons_volume__actions__none">Nichts tun</string> | ||
| <string name="pref_buttons_volume__actions__text_size">Lautstärketasten ändern die Textgröße</string> | ||
| <string name="pref_buttons_volume__actions__history">Navigieren im Sendeverlauf</string> |
There was a problem hiding this comment.
Machine-translated, probably wrong.
There was a problem hiding this comment.
The biggest problem here is behavior.
-
Index is saved per-buffer, but we are using a global array of sent messages. Sending messages in another buffer will make index in current one invalid.
-
More importantly, when pressing up, current input is preserved. But when you navigate up AND edit a previous message AND navigate elsewhere, that last input is NOT preserved. Moreover, if you send it, the NEXT input that you type in is NOT preserved when navigating away. This is not an edge case and should be addressed.
-
When switching between messages the cursor flickers to start of the string and to end, this can probably be avoided?
Finally, in #553 the user asked about history navigation with Up/Down arrow keys, NOT volume buttons, and this PR doesn't fix that so it shouldn't have been closed
| @@ -64,15 +64,8 @@ import com.ubergeek42.WeechatAndroid.upload.i | |||
| import com.ubergeek42.WeechatAndroid.upload.insertAddingSpacesAsNeeded | |||
| import com.ubergeek42.WeechatAndroid.upload.suppress | |||
| import com.ubergeek42.WeechatAndroid.upload.validateUploadConfig | |||
| import com.ubergeek42.WeechatAndroid.utils.* | |||
There was a problem hiding this comment.
Nit: not a fan of wildcard imports, would rather prefer smaller diff
app/src/main/java/com/ubergeek42/WeechatAndroid/fragments/BufferFragment.kt
Show resolved
Hide resolved
app/src/main/java/com/ubergeek42/WeechatAndroid/utils/MigratePreferences.kt
Show resolved
Hide resolved
I don't think this is a real issue since we don't have per-buffer history. What do you suggest instead?
Resolved by removing
That's correct. I don't think I want to fix that, that would basically mean introducing some kind of forking history. At which point do you forget these edits of past sent messages? Do you add a new version in-between that's preserved in
Ah nice catch. That's because I don't reset the index when sending. |
The navigation state is saved and restored along with BufferFragment's lifecycle.
The deprecated preference is migrated to the correspondig volume role.
Supersedes #297. Fixes #553.