Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy SwiftSDK sample app #311

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

mohssenfathi
Copy link
Contributor

Description

Removing the old SwiftSDK sample app since most of the example cases are outdated or replaced by the new UberSDK sample app. In a future PR, I will add examples for the "Request a Ride Button".

Changes

Test values

Two new sample Info plists were added, testInfo.plist and testInfoNoServerToken.plist to support testing.

Remove SwiftSDK

The entire SwiftSDK sample app has been deleted. Test cases related to UberRides have been moved to the UberSDK sample app.

Configuration -> TokenManager

References to Configuration.shared.defaultAccessTokenIdentifier and Configuration.shared.defaultKeychainAccessGroup have been updated to use the TokenManager equivalent.

Testing

All UberRides test classes were moved from the SwiftSDK app to the UberSDK app. All test cases should pass under UberSDK.

@mohssenfathi mohssenfathi marked this pull request as ready for review August 12, 2024 21:07
@mohssenfathi mohssenfathi merged commit d91ca25 into uber:2.x Aug 20, 2024
4 checks passed
@mohssenfathi mohssenfathi deleted the remove-swift-sdk branch August 20, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants