Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try testing numpy <2 and >=2 #409

Closed
wants to merge 10 commits into from
Closed

try testing numpy <2 and >=2 #409

wants to merge 10 commits into from

Conversation

ajfriend
Copy link
Contributor

@ajfriend ajfriend commented Oct 5, 2024

No description provided.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (5d9acb0) to head (92ddaeb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          28       28           
  Lines        1407     1412    +5     
=======================================
+ Hits         1399     1404    +5     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajfriend ajfriend marked this pull request as draft October 5, 2024 18:07
ajfriend and others added 3 commits October 5, 2024 11:11
* Add failing test

* Explicitly convert to str before calling _cy.str_to_int
@ajfriend
Copy link
Contributor Author

ajfriend commented Oct 5, 2024

Abandon in favor of #410

@ajfriend ajfriend closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants