bind cell_to_child_pos / child_pos_to_cell #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
==========================================
+ Coverage 99.33% 99.34% +0.01%
==========================================
Files 28 28
Lines 1354 1378 +24
==========================================
+ Hits 1345 1369 +24
Misses 9 9 ☔ View full report in Codecov by Sentry. |
dfellis
reviewed
Sep 27, 2024
| @@ -922,6 +922,65 @@ def local_ij_to_cell(origin, i, j): | |||
| return h | |||
|
|
|||
|
|
|||
| def cell_to_child_pos(child, parent_res): | |||
| """ | |||
| TODO | |||
There was a problem hiding this comment.
These TODOs should be filled in before merging
ajfriend
added a commit
that referenced
this pull request
Sep 27, 2024
ajfriend
added a commit
that referenced
this pull request
Sep 27, 2024
* cell_to_child_pos and child_pos_to_cell * start exposing cell_to_children_size * checking resolutions * cell_to_children_size python function * adding tests from #404 * fiddling * fix test_cell_to_vertex; helps coverage by removing untouched branch * more tests * lint * exhaustive test for a few resolution pairs * lint * doc strings * error messages * stricter test * playing with argument order. example code in tests looks nicer * use parent_res instead of res * Use `res_*` instead of `*_res` * fix up changelog
|
Closing in favor of #405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.