Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading result from s3 #66

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jankaifer
Copy link

context is in #65

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jankaifer
✅ jan2893
❌ jan.kaifer


jan.kaifer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jankaifer jankaifer force-pushed the jankaifer/add-support-for-downloading-result-from-s3 branch from d935473 to b0f1f85 Compare October 15, 2024 14:35
@jankaifer jankaifer force-pushed the jankaifer/add-support-for-downloading-result-from-s3 branch from b0f1f85 to 8e536d2 Compare October 15, 2024 14:37
Comment on lines +85 to +87
if r.ResultOutput.NextToken == nil || *r.ResultOutput.NextToken == "" {
return &r, nil
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An interesting detail is that I fetch that s3 file only if there are multiple pages. If all results are present on the first page, then we don't need to download the S3 file.

I fetch the first page every time because we need metadata information anyway (like types of columns etc.). And doing one extra request is not that problematic for large queries anyway.

@jankaifer jankaifer changed the title JankAdd support for downloading result from s3 Add support for downloading result from s3 Oct 15, 2024
go/rows.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants