Break splitBlocksOn into a new hook #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 87.83% 87.63% -0.21%
==========================================
Files 63 65 +2
Lines 7885 7916 +31
==========================================
+ Hits 6926 6937 +11
- Misses 776 798 +22
+ Partials 183 181 -2 ☔ View full report in Codecov by Sentry. |
yuxincs
force-pushed
the
yuxincs/break-split-blocks
branch
from
a6605e3
to
5bba008
Compare
sonalmahajan15
approved these changes
Sep 30, 2024
yuxincs
force-pushed
the
yuxincs/break-nonnil-return
branch
from
10acb30
to
152ec48
Compare
yuxincs
force-pushed
the
yuxincs/break-split-blocks
branch
from
20f09c3
to
f9f73a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #279, this PR breaks the logic that splits the CFG block upon seeing a trusted function into a separate strongly-typed hook for better maintainability and slightly better performance (due to fewer lookups in hook points). It introduces no functionality changes.