Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip the path of the mockgen executable when recording invocation #82

Merged
merged 1 commit into from
Sep 15, 2023
Merged

strip the path of the mockgen executable when recording invocation #82

merged 1 commit into from
Sep 15, 2023

Conversation

marten-seemann
Copy link
Contributor

Fixes #80.

This PR implements the first suggestion mentioned in the issue. Only the filename of the executable (usually mockgen) will be recorded.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

JacobOaks
JacobOaks approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is alright since I don't see much value in having the full path of mockgen printed anyways.

@JacobOaks JacobOaks merged commit 7826b9c into uber-go:main Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobOaks JacobOaks JacobOaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

non-reproducible mocks due to recording of invocation arguments
3 participants
@marten-seemann @CLAassistant @JacobOaks