Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking whether all expectations have been met #21

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

FlorianLoch
Copy link
Contributor

As suggested and outlined in #10

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2023

CLA assistant check
All committers have signed the CLA.

@FlorianLoch
Copy link
Contributor Author

In case you are wondering why the commits are so old: I made this PR initially against golang/mock.

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good to me, left a couple of suggestions re: naming and method ordering.

gomock/callset.go Outdated Show resolved Hide resolved
gomock/controller.go Outdated Show resolved Hide resolved
gomock/controller.go Outdated Show resolved Hide resolved
gomock/controller.go Outdated Show resolved Hide resolved
@sywhang sywhang merged commit e86b1bf into uber-go:main Jun 30, 2023
2 checks passed
sywhang pushed a commit to sywhang/mock that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants