feat: add runtime to fxevent.Run events #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1240 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 35 35
Lines 2918 2924 +6
=======================================
+ Hits 2872 2878 +6
Misses 38 38
Partials 8 8 ☔ View full report in Codecov by Sentry. |
r-hang
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds runtime info of constructors and decorators to Run events,
and the runtime of every constructor and decorator (including ones created
by fx.Supply and fx.Replace) will be logged when logging Run events. This
will help us identify which part of the dependency graph takes long to construct.
Closes #1213