Qrequest: Handle arrays differently.

* Don't dynamically create properties. This is more robust to users who supply names like ____VAR____ as a surprise. Also, PHP is going to discourage dynamic properties. * Add get(), set(), has(), get_a(), set_a(), has_a(). * Remove allow_a().
ubc · Dec 16, 2021 · 44ed524 · 44ed524
1 parent 3ce3f5c
commit 44ed524
Show file tree

Hide file tree

Showing 10 changed files with 163 additions and 168 deletions.
diff --git a/autoassign.php b/autoassign.php
@@ -30,7 +30,6 @@
 }
 
 // PC selection
-$Qreq->allow_a("pap", "p");
 if (!isset($Qreq->has_pcc) && isset($Qreq->pcs)) {
     $Qreq->has_pcc = true;
     foreach (preg_split('/\s+/', $Qreq->pcs) as $n) {

diff --git a/bulkassign.php b/bulkassign.php
@@ -212,18 +212,18 @@ function complete_assignment($qreq, $callback) {
 
 echo '<div id="foldoptions" class="lg foldc fold2c fold3c"><label>',
     'Default action:&nbsp; ',
-    Ht::select("default_action", array("guess" => "guess from input",
-                                       "primary" => "assign primary reviews",
-                                       "secondary" => "assign secondary reviews",
-                                       "pcreview" => "assign optional PC reviews",
-                                       "metareview" => "assign metareviews",
-                                       "review" => "assign external reviews",
-                                       "conflict" => "assign PC conflicts",
-                                       "lead" => "assign discussion leads",
-                                       "shepherd" => "assign shepherds",
-                                       "settag" => "set tags",
-                                       "preference" => "set reviewer preferences"),
-               $Qreq->get("default_action", "guess"),
+    Ht::select("default_action", ["guess" => "guess from input",
+                                  "primary" => "assign primary reviews",
+                                  "secondary" => "assign secondary reviews",
+                                  "pcreview" => "assign optional PC reviews",
+                                  "metareview" => "assign metareviews",
+                                  "review" => "assign external reviews",
+                                  "conflict" => "assign PC conflicts",
+                                  "lead" => "assign discussion leads",
+                                  "shepherd" => "assign shepherds",
+                                  "settag" => "set tags",
+                                  "preference" => "set reviewer preferences"],
+               $Qreq->default_action ?? "guess",
                ["id" => "tsel"]),
     '</label>';
 Ht::stash_script('$(function(){