Merge pull request #677 from ubc/fix-attachment-removal

Fix attachment removal issue
ubc · Feb 2, 2018 · b5dcc11 · b5dcc11
2 parents e2413ec + 4fbceb8
commit b5dcc11
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/compair/static/modules/answer/answer-module.js b/compair/static/modules/answer/answer-module.js
@@ -411,7 +411,7 @@ module.controller(
         }
 
         $scope.uploader = answerAttachService.getUploader();
-        $scope.resetFileUploader = answerAttachService.reset();
+        $scope.resetFileUploader = answerAttachService.reset;
 
         $scope.deleteFile = function(file) {
             $scope.answer.file = null;

diff --git a/compair/static/modules/assignment/assignment-module.js b/compair/static/modules/assignment/assignment-module.js
@@ -1262,7 +1262,7 @@ module.controller("AssignmentWriteController",
         $scope.editorOptions = EditorOptions.basic;
         $scope.PairingAlgorithm = PairingAlgorithm;
         $scope.uploader = attachService.getUploader();
-        $scope.resetFileUploader = attachService.reset();
+        $scope.resetFileUploader = attachService.reset;
         $scope.recommended_comparisons = Math.floor(required_rounds / 2);
 
         $scope.rankLimitOptions = [

diff --git a/compair/static/modules/attachment/attachment-module.js b/compair/static/modules/attachment/attachment-module.js
@@ -271,9 +271,7 @@ module.service('attachService',
     };
 
     var reset = function() {
-        return function() {
-            file = null;
-        }
+        file = null;
     };
 
     var getFile = function() {
@@ -389,9 +387,7 @@ module.service('answerAttachService',
     var uploadedCallback = function(fileItem) {};
 
     var reset = function() {
-        return function() {
-            file = null;
-        };
+        file = null;
     };
 
     var getFile = function() {