Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minification from remote library assets #70

Closed
wants to merge 3 commits into from
Closed

Conversation

joelpittet
Copy link
Collaborator

Core doesn't do this so there is no precedence, there is some in webform but I can't see how minifying a remote asset should be allowed.

The problem is when the remote asset throws an error and the result is cached it fails with

Exception: Only file CSS assets can be optimized. in Drupal\Core\Asset\CssOptimizer->optimize() (line 43 of /var/www/mds/releases/107/public/core/lib/Drupal/Core/Asset/CssOptimizer.php).

and

Warning: file_get_contents(https://cloud.typography.com/7574694/6365152/css/fonts.css): Failed to open stream: HTTP request failed! HTTP/1.1 403 Forbidden
 in Drupal\system\Controller\CssAssetController->generateHash() (line 43 of /var/www/mds/releases/107/public/core/lib/Drupal/Core/Asset/AssetGroupSetHashTrait.php) #0 /var/www/mds/releases/107/public/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
#1 [internal function]: _drupal_error_handler()```

occupant and others added 3 commits December 11, 2023 12:05
Starterkit replace config and other areas that get missed by core
@joelpittet joelpittet requested a review from occupant January 3, 2024 00:18
@joelpittet joelpittet closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants