Content revision for demographics section #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucecrevensten
force-pushed
the
demo_edits_oct
branch
from
6823c98 to
4e98b1e
Compare
cstephen
requested changes
Oct 24, 2024
There was a problem hiding this comment.
I gave the bulleted list in #676 and the associated Google Doc a careful review with my local NCR instance pointed at http://development.earthmaps.io. I found a handful of issues, which have all been indicated in PR code comments.
One other very nitty nit pick: The document mentions hiding health information for communities with an adult population of 50 or more, but we are showing health information for communities with a total population of 50 or more. Does this matter? Implementing it any other way sounds like a decent amount of work.
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
Co-authored-by: Craig Stephenson <[email protected]>
cstephen
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #675
Closes #676
See associated docs for details on what is changing.
For testing, point the service to the dev API instance. Review the documentation and ensure that all points are addressed (or commented on in the doc as needing more discussion).