Fix credits page bio centering at very wide resolutions #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucecrevensten
approved these changes
May 7, 2024
cstephen
added a commit
that referenced
this pull request
May 8, 2024
cstephen
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629.
This fixes the issue described in #629. The problem is that, at very wide resolutions, bio images cap out at their native width of 300px and are floated to the right. The extra whitespace to the left of the bio image gives the appearance of the grid system failing, even though it is still working as intended. This has been fixed by setting bio images to
width: 100%so they scale up when their parent div is greater than 300px wide.To test, run the app, view the credits page, and make your browser very wide (maybe even wider than your laptop screen). Verify that everything on the page still lines up as expected.