Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds people credits page #572

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Adds people credits page #572

merged 6 commits into from
Oct 10, 2023

Conversation

brucecrevensten
Copy link
Member

Testing:

  • Go to the new Credits menu option!
  • Play with screen sizes; it may or may not be passable. (If you can, just fix it in-place in this branch).
  • Check for any goofs with glyphs or other text malformations (fix)

cstephen
cstephen requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@cstephen cstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and reads great! I found a few tiny things to fix. See the PR review comments.

pages/credits.vue Outdated Show resolved Hide resolved
pages/credits.vue Outdated Show resolved Hide resolved
pages/credits.vue Outdated Show resolved Hide resolved
brucecrevensten and others added 3 commits October 9, 2023 18:36
@brucecrevensten @cstephen
Update pages/credits.vue
ed7a869 
Co-authored-by: Craig Stephenson <[email protected]>
@brucecrevensten @cstephen
Update pages/credits.vue
e8cb187 
Co-authored-by: Craig Stephenson <[email protected]>
@brucecrevensten @cstephen
Update pages/credits.vue
844861f 
Co-authored-by: Craig Stephenson <[email protected]>
@brucecrevensten
Copy link
Member Author

@cstephen good catches! review + merge plz

@cstephen cstephen self-requested a review October 10, 2023 18:05
@cstephen cstephen merged commit c6c826e into main Oct 10, 2023
1 check failed
@cstephen cstephen deleted the increase_academia branch October 10, 2023 18:05
@brucecrevensten brucecrevensten mentioned this pull request Oct 11, 2023
Closed
cstephen pushed a commit that referenced this pull request Oct 12, 2023
@brucecrevensten @cstephen
Adds people credits page (#572)
99e82c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstephen cstephen cstephen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brucecrevensten @cstephen