Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bulma #127

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Upgrade bulma #127

wants to merge 5 commits into from

Conversation

brucecrevensten
Copy link
Member

Do an npm install to get the right versions of things.

Things to test:

  • Is the home page layout ok?
  • What about the individual sections below the main intro content -- it will look a bit different but I think it's OK for now
  • Click on a topic. Is the page showing all matching items OK?
  • Do bios look OK at the end of items?
  • Go to the People page. Does it look OK?

@cstephen cstephen self-requested a review July 29, 2024 20:18
Copy link
Contributor

@cstephen cstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks mostly good to me! It looks very close to before the Bulma upgrade.

A few things I noticed:

  • The tag sections below the intro stuff on the front page look good, but are missing the vertical dashed lines that gave it more of newspaper feel. Also, the vertical dashed lines are still present on the tag category pages, so this is a tad consistent.

Front page (no vertical dashed lines):

image

Tag page (with vertical dashed lines):

image

  • The responsiveness feels a little bit off on the tag category pages. Items are displayed in either a single column, a 2-item grid, or a 4-item grid. For the browser window size I normally use, it's attempting to display the items in a 4-item grid but it wraps the fourth item on a line by itself.

image

  • Map layer options look a little cramped. The map layer names could benefit from more vertical margin/padding IMO, and also the right-arrow is placed on a line by itself instead of at the end of the map layer text, which looks a little off.

image

@brucecrevensten brucecrevensten marked this pull request as draft July 30, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants