Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job names so they can be selected as required statuses #11

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

masklinn
Copy link
Collaborator

@masklinn masklinn commented Oct 8, 2024

Usually there are not many jobs and they don't overlap so their naming is easy. In this case I forgot that statuses are per-job not per file or anything, so

  • the naming overlap between the "normal" python tests and the release made knowing which was which much harder than necessary
  • the rust and python checks literally having the same job name made one of them (not sure which) impossible to select
  • having all the rust stuff as a single "checks" jobs didn't help either, split it into checks and tests to more or less mirror the python stuff
  • prefix jobs with their language as it's not out the question that the repository would grow e.g. JS bindings in neon, or a C API for FFI, or whatever, and those would need to be clearly identified

Usually there are not many jobs and they don't overlap so their naming
is easy. In this case I forgot that statuses are per-job not per file
or anything, so

- the naming overlap between the "normal" python tests and the release
  made knowing which was which much harder than necessary
- the rust and python checks literally having the same job name made
  one of them (not sure which) impossible to select
- having all the rust stuff as a single "checks" jobs didn't help
  either, split it into checks and tests to more or less mirror the
  python stuff
- prefix jobs with their language as it's not out the question that
  the repository would grow e.g. JS bindings in neon, or a C API for
  FFI, or whatever, and those would need to be clearly identified
@masklinn masklinn merged commit 2cd7c6a into ua-parser:main Oct 8, 2024
13 checks passed
@masklinn masklinn deleted the sensible-jobs branch October 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant