Brand/Model Support with Minimal changes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsonntag
force-pushed
the
BrandModelSupport
branch
from
af1a7a1
to
bdef99c
Compare
|
All tests passing. |
mbarbon
added a commit
to mbarbon/uap-java
that referenced
this pull request
Sep 2, 2017
|
Works great. As this repository seems not maintained much, I applied the patch locally. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added brand and model support with the goal of altering the existing code base as little as possible. This differs from the approach taken in pull request #4. By making an effort to make only small changes to the code base, the flow and readability of the code remains in tact.
Thank you for maintaining such a great repository. Please let me know if you have any questions or comments.