DEV-127: replace fetch calls with axios #480
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Share plan fails and droppable thing doesn't work anymore
@josephined21 help?
| axios | ||
| .patch(getAPI(window) + '/plans/update', body, { | ||
| headers: { ContentType: 'application/json', Authorization: `Bearer ${token}` }, | ||
| }) |
There was a problem hiding this comment.
update plan name / majors
| axios | ||
| .patch(getAPI(window) + '/years/changeOrder', body, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', |
There was a problem hiding this comment.
has this been addressed?
| @@ -232,32 +231,30 @@ const CourseList: FC<Props> = ({ mode }) => { | |||
| newTerm: destination.semester, | |||
| }; | |||
|
|
|||
| let res: any = await fetch(getAPI(window) + '/courses/dragged', { | |||
| method: 'PATCH', | |||
| let res = await axios.patch(getAPI(window) + '/courses/dragged', body, { | |||
There was a problem hiding this comment.
dragging courses to new semester works
error check too
| axios | ||
| .post(getAPI(window) + '/courses', body, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${token}`, |
There was a problem hiding this comment.
adding course from Semester works
| axios | ||
| .patch(getAPI(window) + '/years/updateName', body, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${token}`, | ||
| }, | ||
| }) |
| if (planList[i]._id === newPlan._id) { | ||
| newPlanList[i] = newPlan; | ||
| } | ||
| const handlePostAddCourse = (plan: Plan) => (data): void => { |
There was a problem hiding this comment.
add course to update
| } | ||
| }); | ||
| newPlan = { ...currentPlan, years: years }; | ||
| axios |
There was a problem hiding this comment.
delete course works
| axios | ||
| .delete(getAPI(window) + '/plans/' + currentPlan._id, { | ||
| headers: { | ||
| Authorization: `Bearer ${token}`, | ||
| }, | ||
| }) |
| Authorization: `Bearer ${token}`, | ||
| }, | ||
| }) | ||
| axios |
| if (error.status === 400) { | ||
| toast.error(error.detail); | ||
| } | ||
| try { |
There was a problem hiding this comment.
add course from coursesearch works
…s function from userService
|
Kudos, SonarCloud Quality Gate passed!
|
description
for sake of consistency, replace all uses of fetch with axios
Also, for DEV-126 Refactor API calls to userService
implementation
for DEV-126:
Refactored API calls:
- Refactored the call in RoadmapComment.tsx with getThreads
from userService
- Wrote getPlanByUser in userService
- Refactored the call in HandleUserInfoSetUpDummy.tsx with
getPlanByUser
- Wrote createNewPlan in userService
- Refactored the call in GenerateNewPlan.tsx
- Wrote getYear in userService
- Refactored the call in HandlePlanShareDummy.tsx
- Wrote deletePlan in userService
- Refactored the call in DeletePlanPopup.tsx
- Refactored the call in Comment.tsx with postNewComment
function in userService
- Refactored the call in NewComment.tsx with postNewThread
function in userService
- Wrote deleteNotifications function in userService
- Refactored the call in Notification.tsx
- Wrote updateYear in userService
- Refactored the call in YearSettingsDropdown.tsx
Not refactored into userService:
- error handling creates a toast
- request has ContentType header in addition to Authorization
header
- empty array returned in error handling
- setSearching(false) called in error handling
- No longer exists in updated DEV-127 branch
- Error handling creates a toast
- Has ContentType header in addition to authorization header
- Has ContentType header in addition to authorization header
- Has ContentType header in addition to authorization header
- Not worth refactoring because attempt to refactor would lead
to more lines of code than what already exist
- Not worth refactoring because attempt to refactor would lead
to more lines of code than what already exist