sdl2.30.9 #81
Merged
sdl2.30.9 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated sdl2.30.9
General:
Merged all previously applied fixes for Linux, Win-GCC, and Android.
Removed the CMake variable SDL_LIBS, as it is no longer needed.
Android:
In HIDDeviceManager.java, the BLUETOOTH_CONNECT permission is currently commented out.
We can uncomment these lines when we upgrade to Android SDK ≥ 31.
iOS / tvOS:
Added the SDL Main sources, and the build is working.
Emscripten:
Some "Unresolved Symbol" errors persist (attempted to increase the limit in the CI system using ulimit without noticeable effect).
Workaround: Disable sdl_joystick_magic and SDL_Threads for now.
CI :
Windows:
Identified issue: In the workflow, the Win-GCC build has a cache issue.
The egor-tensin/setup-mingw action tries to delete a nonexistent file.
Fix: Skip setup-mingw if the cache is already present.
Emscripten:
When using script/cmake_emscripten.sh, a web build is expected, but it results in a native build.
Fix: Added a check in cmake_emscripten.sh.
iOS / tvOS:
Added caching for CMake and cleanup before release (resolves issue #29).
Improvement: Use jwlawson/actions-setup-cmake, as done in rbfx. TODO ?
Issues:
iOS / tvOS:
Sample artifacts are not included in the package.
Check the interaction between CPACK and XCode, possibly related to the CFBundle name.
TO FIX