Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Build Fixes #55

Merged
merged 5 commits into from
Oct 28, 2023
Merged

Conversation

SirNate0
Copy link
Collaborator

  • Prefer the U3D shell.html rather than generating one from the emscripten default. (Fixes Web Build Slowed by Log Output #54)
  • Remove the custom emscripten toolchain file. Instead, use the one installed by the emsdk, which is available by calling the cmake_emscripten script through emcmake.
  • Backport a minor SDL change to setWindowTitle that is needed for newer versions of emscripten. As I have corrected it, it should be backwards compatible to old versions.
  • Add a click-to-play overlay and delay running the web assembly until the user click it. Untested on mobile. Fixes Audio fails on web without user interaction #53
  • Add a separate web workflow. This demonstrates how to use emcmake. Additionally, it should eventually be used to update samples on the website.

@SirNate0
Copy link
Collaborator Author

I tested the click to play on my phone and it worked fine, and I rebased onto the last change to master (I missed it earlier with having multiple remotes).

The mingw windows builds have been failing for a while now because of an issue with the action installing it (I think there is a workaround, but that can be done in a separate PR), as has the QA build.

If you want, I could disable the wasm builds within the Linux workflow, but otherwise I think it's ready to be merged.

@klaussilveira
Copy link
Contributor

Let's merge it!

@klaussilveira klaussilveira merged commit 3998515 into u3d-community:master Oct 28, 2023
50 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Build Slowed by Log Output Audio fails on web without user interaction
2 participants