Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get cpu client working on freebsd #287

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Get cpu client working on freebsd #287

merged 2 commits into from
Oct 10, 2024

Conversation

rminnich
Copy link
Member

@rminnich rminnich commented Oct 3, 2024

needs testing ...

@rminnich
Get cpu client working on freebsd
084fa8f 
Signed-off-by: Ronald G. Minnich <[email protected]>
@rminnich
Copy link
Member Author

rminnich commented Oct 3, 2024

The cpu command works on freebsd now
PWD=/ ./cpu -namespace=/home -9p=false -nfs=true -sp 22 linoderoot
works

@rminnich
Copy link
Member Author

rminnich commented Oct 3, 2024

I've tested it and it works, so that's something anyway

@bsdimp
Copy link
Collaborator

bsdimp commented Oct 4, 2024

This is cool... I wonder why there's no error for the permission thing...

bsdimp
bsdimp approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@bsdimp bsdimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works :)

There were a couple of questions I had. I can almost read 'go' most days, but this looks good from what I can tell.

client/cpu9p_unix_test.go Show resolved Hide resolved
client/cpu_freebsd.go Outdated Show resolved Hide resolved
client/getattr_freebsd.go Show resolved Hide resolved
client/getattr_freebsd.go Outdated Show resolved Hide resolved
binjip978
binjip978 reviewed Oct 4, 2024
View reviewed changes
client/cpu9p_unix.go Outdated Show resolved Hide resolved
@rminnich
Tidy up following review comments.
4920087 
Signed-off-by: Ronald G. Minnich <[email protected]>
@rminnich rminnich merged commit 05895c1 into u-root:main Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsdimp bsdimp bsdimp approved these changes

@binjip978 binjip978 binjip978 approved these changes

@rjkroege rjkroege Awaiting requested review from rjkroege

@Lencerf Lencerf Awaiting requested review from Lencerf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rminnich @bsdimp @binjip978