client: add GetHostUser for u@host and .ssh/config #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rminnich
force-pushed
the
host@user
branch
2 times, most recently
from
3d8bcaf
to
7132caa
Compare
binjip978
reviewed
Jul 13, 2024
Since 2017 cpu used $USER as the user. Now that it supports ssh, it needs better processing. Add GetHostUser, which takes a string in [user@]host form, and returns a host and user name as follows: if user@host form, return the host and user. Look up the host in .ssh/config; if found, and there is a UserName record, return that UserName Otherwise return host and $USER. If a host entry is found in .ssh/config, the HostName from that entry is used. This means that code that used GetHost should start using GetHostUser. Signed-off-by: Ron Minnich <[email protected]>
binjip978
approved these changes
Jul 14, 2024
rminnich
added a commit
to rminnich/cpu
that referenced
this pull request
Jul 20, 2024
Since 2017 cpu used $USER as the user. Now that it supports ssh, it needs better processing. Add GetHostUser, which takes a string in [user@]host form, and returns a host and user name as follows: if user@host form, return the host and user. Look up the host in .ssh/config; if found, and there is a UserName record, return that UserName Otherwise return host and $USER. If a host entry is found in .ssh/config, the HostName from that entry is used. This means that code that used GetHost should start using GetHostUser. Signed-off-by: Ron Minnich <[email protected]> Co-authored-by: Ron Minnich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2017 cpu used $USER as the user. Now that it supports ssh, it needs better processing.
Add GetHostUser, which takes a string in [user@]host form, and returns a host and user name as follows:
if user@host form, return the host and user.
Look up the host in .ssh/config; if found, and
there is a UserName record, return that UserName
Otherwise return host and $USER.
If a host entry is found in .ssh/config, the
HostName from that entry is used.
This means that code that used GetHost should start using GetHostUser.