cpud: default to building cpud with mDNS enabled #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relies on a double negative: // go:build !nomDNS u-root is not properly handling -tags mDNS in the command line, and we kind of need this, so I will leave it to Google to work around it. Signed-off-by: Ronald G Minnich <[email protected]>
|
hold off on this, still working to find out what's up. I mean approve if you want but I don't commit yet. |
|
not needed. Not sure what was going wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on a double negative:
// go:build !nomDNS
u-root is not properly handling
-tags mDNS
in the command line, and we kind of need this, so
I will leave it to Google to work around it.