add revoke

typelevel · Aug 16, 2023 · 1f5877f · 1f5877f
1 parent 2005f5a
commit 1f5877f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/modules/core/shared/src/main/scala/data/Completion.scala b/modules/core/shared/src/main/scala/data/Completion.scala
@@ -62,6 +62,7 @@ object Completion {
   case object SetConstraints            extends Completion
   case object Explain                   extends Completion
   case object Grant                     extends Completion
+  case object Revoke                    extends Completion
   // more ...
 
   /**

diff --git a/modules/core/shared/src/main/scala/net/message/CommandComplete.scala b/modules/core/shared/src/main/scala/net/message/CommandComplete.scala
@@ -100,6 +100,7 @@ object CommandComplete {
     case "SET CONSTRAINTS"            => apply(Completion.SetConstraints)
     case "EXPLAIN"                    => apply(Completion.Explain)
     case "GRANT"                      => apply(Completion.Grant)
+    case "REVOKE"                     => apply(Completion.Revoke)
     // more .. fill in as we hit them
 
     case s                  => apply(Completion.Unknown(s))

diff --git a/modules/tests/shared/src/test/scala/CommandTest.scala b/modules/tests/shared/src/test/scala/CommandTest.scala
@@ -312,6 +312,13 @@ class CommandTest extends SkunkTest {
         TO skunk_role
        """.command
 
+  val revoke: Command[Void] =
+    sql"""
+        REVOKE ALL PRIVILEGES
+        ON ALL TABLES IN SCHEMA public
+        FROM skunk_role
+       """.command
+
   sessionTest("create table, create index, drop index, alter table and drop table") { s =>
     for {
       c <- s.execute(createTable)
@@ -535,11 +542,13 @@ class CommandTest extends SkunkTest {
       .as("ok")
   }
 
-  sessionTest("grant") { s =>
+  sessionTest("grant, revoke") { s =>
     for{
       _ <- s.execute(createRole)
       c <- s.execute(grant)
       _ <- assert("completion", c == Completion.Grant)
+      c <- s.execute(revoke)
+      _ <- assert("completion", c == Completion.Revoke)
       _ <- s.execute(dropRole)
       _ <- s.assertHealthy
     } yield "ok"