Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-scalafix to 0.13.0 #749

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Update sbt-scalafix to 0.13.0 #749

merged 1 commit into from
Sep 28, 2024

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates ch.epfl.scala:sbt-scalafix from 0.12.1 to 0.13.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" }
}]
labels: sbt-plugin-update, early-semver-major, semver-spec-minor, commit-count:1

@mergify mergify bot added the scalafix label Sep 28, 2024
@mergify mergify bot requested a review from armanbilge September 28, 2024 00:21
@mzuehlke mzuehlke merged commit 7901050 into main Sep 28, 2024
15 checks passed
@mzuehlke mzuehlke deleted the update/sbt-scalafix-0.13.0 branch September 28, 2024 11:51
@armanbilge
Copy link
Member

armanbilge commented Oct 5, 2024

This was a breaking bump for sbt-scalafix so we might want to bump the sbt-typelevel base version πŸ€”

The release notes for sbt-scalafix say:

Dropped support for sbt 1.3.x

Which isn't a problem for us (we already require a newer sbt version).

However, this also ships scalafix v0.13.0 which includes some breaking changes for rule authors ...

Scalameta was bumped from 4.9.3 to 4.10.1 ... breaking forward & backward compatibility

@mzuehlke
Copy link
Collaborator

Good comment, I was missing that change.
I will add another comment on #751

@armanbilge
Copy link
Member

armanbilge commented Oct 10, 2024

I decided that we can relatively safely move forward without bumping the base version, see #751 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants