Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install sbt via brew on macOS runners #681

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

armanbilge
Copy link
Member

Fixes #680. To keep things simple we do the install for all macOS runners.

@armanbilge armanbilge marked this pull request as ready for review February 22, 2024 04:37
Copy link
Collaborator

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution.

While looking at the generate ci.yml
I see that all jobs except "Build and Test" contain a lot of steps that will never be executed because of their guards, and all the other jobs are only running on "ubuntu".

@armanbilge
Copy link
Member Author

Thanks!

While looking at the generate ci.yml
I see that all jobs except "Build and Test" contain a lot of steps that will never be executed because of their guards, and all the other jobs are only running on "ubuntu".

Yes this is currently the case because we use githubWorkflowJobSetup for all jobs. If we are clever we could probably filter irrelevant steps. In practice, it doesn't matter too much besides the bloat/noise.

@armanbilge armanbilge merged commit 2e70f50 into typelevel:main Feb 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install sbt with brew on macOS 13, 14
3 participants