Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packaging sources from all managed directories #672

Merged

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Dec 13, 2023

When using generators that put sources in custom directories, eg sbt-avro. The generated sources are by default in a dedicated folder eg. sourceManaged / avro / $config instead of sourceManaged / $config.

Using sbt-typelevel fails the packageSrc with this setup.

As the custom managed source path is added to the managedSourceDirectories, check the path given from the mapping is part of one of the source instead of the default sourceManaged.

@mergify mergify bot added the settings label Dec 13, 2023
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@armanbilge armanbilge merged commit 8ebcebc into typelevel:main Dec 13, 2023
14 checks passed
@RustedBones RustedBones deleted the allow-custom-managed-src-dirs branch December 14, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants