Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validated and validatedNec to boolean #319

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Add validated and validatedNec to boolean #319

merged 1 commit into from
Feb 28, 2022

Conversation

TimoMeijer
Copy link
Contributor

@TimoMeijer TimoMeijer commented Feb 28, 2022 •
edited
Loading

These additional extensions aligns the boolean to validated methods with similar methods in Cats, which usually provide all three options.

danicheg
danicheg reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that contribution. One suggestion: it would be great if you could add tests for new methods. They could be trivial but would help to have good test coverage.

danicheg
danicheg approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@benhutchison
Copy link
Member

Thanks @TimoMeijer

@benhutchison benhutchison merged commit fcd5268 into typelevel:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danicheg danicheg danicheg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimoMeijer @benhutchison @danicheg